Horton
Menu

Re: Extend COPY FROM with HEADER <integer> to skip multiple lines

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Shinya Kato <shinya11.kato@gmail.com>
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@postgresql.org
Date: 2025-06-27T03:22:17Z
Lists: pgsql-hackers 

On 2025/06/27 11:55, Shinya Kato wrote:
> I thought about the approach, and had a minor concern about the following inconsistency between the option and its internal implementation:
> - When the option is set to "MATCH", header_line becomes -1.
> - When the option is set to -1, it's an error.

I think this inconsistency is acceptable, since users won't encounter it directly.
Also the value -1 isn't used explicitly, i.e., it's always referenced through a macro
for "match", which keeps the code readable and understandable.


> However, your patch is clear, and it seems we don't need to worry about this concern.
> Your patch looks good to me.

Thanks for reviewing the patch! I've marked it as ready for committer.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Support multi-line headers in COPY FROM command.