Horton

Re: pgsql: Restrict the use of temporary namespace in two-phase transaction

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Date: 2019-01-18T01:08:07Z
Lists: pgsql-hackers 
Michael Paquier <michael@paquier.xyz> writes:
> I have been monitoring the buildfarm and crake is complaining:
> https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=crake&br=HEAD

> I am actually amazed to see the planner choose a parallel plan for
> that,

That's due to force_parallel_mode = regress, I imagine.

> Anyway, it seems to me that this is pointing out to another issue:
> current_schema() can trigger a namespace creation, hence shouldn't we
> mark it as PARALLEL UNSAFE and make sure that we never run into this
> problem?

That seems a bit annoying, but maybe we have little choice?

			regards, tom lane

Commits

  1. Adjust error message

  2. Enforce non-parallel plan when calling current_schema() in newly-added test

  3. Restrict the use of temporary namespace in two-phase transactions