Re: _WINSOCK_DEPRECATED_NO_WARNINGS
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Glen Knowles <gknowles@ieee.org>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-11-17T03:46:55Z
Lists: pgsql-hackers
Glen Knowles <gknowles@ieee.org> writes: > On Thu, Nov 16, 2017 at 8:37 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> but evidently it chose the wrong cutoff for when to enable that >> symbol, because woodlouse is (or claims to be) running VS2013. > It's actually checking the wrong thing, the problem is the version of the > Windows SDK, and while the one installed by default with VS2015 might be > the right place to cutoff it's not uncommon to have multiple versions of > the SDK (and VS) in various combinations. Ah, interesting point --- though it's not clear that woodlouse is actually running a mixture of SDK/VS releases. > Or you could just define it unconditionally. :) Already done that way. I wonder though if this means the other tests of _MSC_VER in our tree are wrong? regards, tom lane
Commits
-
Define _WINSOCK_DEPRECATED_NO_WARNINGS in all MSVC builds.
- ff2d4356f8b1 11.0 landed