Re: Fixing WAL instability in various TAP tests

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Noah Misch <noah@leadboat.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-09-25T15:43:16Z
Lists: pgsql-hackers
Mark Dilger <mark.dilger@enterprisedb.com> writes:
> You may be right, but the conversation about "all possible settings" was started by Noah.  I was really just talking about tests that depend on wal files not being removed, but taking no action to guarantee that, merely trusting that under default settings they won't be.  I can't square that design against other TAP tests that do take measures to prevent wal files being removed.  Why is the precaution taken in some tests but not others?

If we are doing something about that in some test cases, I'd agree with
doing the same thing in others that need it.  It seems more likely to
be an oversight than an intentional test condition.

			regards, tom lane



Commits

  1. Fix instability in contrib/bloom TAP tests.

  2. Re-enable contrib/bloom's TAP tests.