Horton

Re: pgsql: Move pg_dump memory routines into pg_dumpmem.c/h and restore com

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Bruce Momjian <bruce@momjian.us>, pgsql-committers@postgresql.org
Date: 2011-11-27T17:42:59Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Move pg_dump memory routines into pg_dumpmem.c/h and restore common.c

Andrew Dunstan <andrew@dunslane.net> writes:
> MSVC is still broken with this change, but now I think we've exposed a 
> long-standing error in the MSVC build system. ...
> AddSimpleFrontend() calls AddDir() which harvests the contents of 
> $(OBJS) from the Makefile for the target. But pg_dumpall doesn't want 
> $(OBJS). We've been benignly but mistakenly building it with them for a 
> quite a few years, but now we can't do that any more, given Bruce's 
> changes. It looks like the fix is to call AddProject() for pg_dumpall 
> instead of AddSimpleFrontend() and then do a little more work ourselves 
> to select exactly what we need.

Maybe it would be better to refactor the makefile so that $(OBJS) is
still sensible to use this way?

			regards, tom lane