Horton

Re: [PATCH] relocation truncated to fit: citus build failure on s390x

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Christoph Berg <myon@debian.org>
Cc: Andres Freund <andres@anarazel.de>, Jason Petersen <jason@citusdata.com>, pgsql-pkg-debian@postgresql.org, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-05-30T17:04:06Z
Lists: pgsql-hackers 
Christoph Berg <myon@debian.org> writes:
> My main point here would be that we are already setting this for all
> extensions for sparc and sparc64, so s390(x) would just follow suit.

For some values of "we", sure ;-).  But I think what is really under
discussion here is whether to change -fpic to -fPIC for all platforms.
It looks like Makefile.netbsd and Makefile.openbsd would be affected along
with Makefile.linux.  Some other platforms such as freebsd are already
in the fPIC-always camp.

			regards, tom lane

Commits

  1. Always use -fPIC, not -fpic, when building shared libraries with gcc.