Horton

Re: [Patch] timezone/zic.c: Fix file handle leak in dolink()

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: zengman <zengman@halodbtech.com>
Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-12-28T16:59:25Z
Lists: pgsql-hackers 
"=?ISO-8859-1?B?emVuZ21hbg==?=" <zengman@halodbtech.com> writes:
> Furthermore, I noticed that some of the test code in `contrib/pg_trgm/trgm_regexp.c` does not check the return value of the `fopen()` call. 
> I'm not sure if it's necessary to make the modification.

Probably not worth the trouble.  This is barely even debug-grade
code, seeing that there's no provision to change the target file
name.  It's clearly not meant for use in unfriendly environments.

			regards, tom lane