Thread

Re: [Patch] timezone/zic.c: Fix file handle leak in dolink()

Tom Lane <tgl@sss.pgh.pa.us> — 2025-12-28T16:56:03Z

"=?gb18030?B?emVuZ21hbg==?=" <zengman@halodbtech.com> writes:
> I noticed a small issue and made a tiny patch to fix it ¡ª it addresses a file handle leak in the dolink() function of src/timezone/zic.c. 

Huh?  The program is going to exit() two lines further down.
What's the point of closing here?

Even if there were a plausible argument for issuing close(),
I wouldn't care to diverge from upstream zic.  If you like
you can go try to persuade the tzdb crew that this is a
useful change.

			regards, tom lane