Re: [Sender Address Forgery]Re: error message when subscription target is a partitioned table

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Michael Paquier <michael@paquier.xyz>
Cc: Arkhena <Arkhena@gmail.com>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Magnus Hagander <magnus@hagander.net>, Tatsuo Ishii <ishii@sraoss.co.jp>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-01-11T01:50:32Z
Lists: pgsql-hackers
On 2019/01/10 19:27, Michael Paquier wrote:
> On Thu, Jan 10, 2019 at 05:58:10PM +0900, Amit Langote wrote:
>> The reason I started this thread is due to this Stack Overflow question:
>>
>> https://stackoverflow.com/questions/53554727/logical-replication-and-declarative-partitioning-in-postgresql-11
>>
>> So, it appears that there may be an element of surprise involved in
>> encountering such an error (despite the documentation).
> 
> Improving the user experience is definitely a good thing in my
> opinion because the current error message can be confusing, so you
> were right to start this thread.  Still I don't agree that classifying
> those relkinds as not supported is right either for consistency with
> the code existing for two years and for the way the code is designed
> to work as rows are replicated on a per-physically-defined relation
> basis.

Okay, I withdraw my objection to the wording proposed by you.

Thanks,
Amit



Commits

  1. Improve error messages for incorrect types of logical replication targets