Horton

Re: Bug in reindexdb's error reporting

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-05-10T14:43:50Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2019-May-10, Julien Rouhaud wrote:
>> I just noticed that reindexdb could report an extraneous message
>> saying an error happened while reindexing a database if it failed
>> reindexing a table or an index.

> Kudos, good find -- that's a 14 years old bug, introduced in this commit:

Yeah :-(.

Patch is good as far as it goes, but I wonder if it'd be smarter to
convert the function's "type" argument from a string to an enum,
and then replace the if/else chains with switches?

			regards, tom lane

Commits

  1. Fix error reporting in reindexdb