Re: idea: log_statement_sample_rate - bottom limit for sampling

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Tomas Vondra <tomas.vondra@2ndquadrant.com>

Cc: Adrien Nayrat <adrien.nayrat@anayrat.info>, pgsql-hackers@lists.postgresql.org

Date: 2019-08-04T19:16:12Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Revert "Add log_statement_sample_rate parameter"
- 75506195da81 13.0 landed
- d5f53a8e26ca 12.0 landed
Revert "Silence compiler warning"
- 4f9ed8f3c5ef 13.0 landed
- d8453ccfbfd6 12.0 landed

Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> OK, I have the revert ready. The one thing I'm wondering about is
> whether we need to revert log_transaction_sample_rate too? I think it's
> pretty much independent feature, so I think we can keep that. Opinions?

Isn't the issue here the interaction between log_transaction_sample_rate
and log_min_duration_statement?  Seems like we have that question
regardless of whether log_statement_sample_limit exists.

			regards, tom lane