Re: Fixing WAL instability in various TAP tests

Mark Dilger <mark.dilger@enterprisedb.com> writes:
>> On Sep 24, 2021, at 10:21 PM, Noah Misch <noah@leadboat.com> wrote:
>>> I would
>>> expect tests which fail under legal alternate GUC settings to be hardened to
>>> explicitly set the GUCs as they need, rather than implicitly relying on the
>>> defaults.

>> That is not the general practice in PostgreSQL tests today.  The buildfarm
>> exercises some settings, so we keep the tests clean for those.  Coping with
>> max_wal_size=2 that way sounds reasonable.  I'm undecided about the value of
>> hardening tests against all possible settings.

> Leaving the tests brittle wastes developer time.

Trying to make them proof against all possible settings would waste
a lot more time, though.

			regards, tom lane