Re: FailedAssertion("pd_idx == pinfo->nparts", File: "execPartition.c", Line: 1689)
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andy Fan <zhihui.fan1213@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
Amit Langote <amitlangote09@gmail.com>,
Justin Pryzby <pryzby@telsasoft.com>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2020-08-06T04:02:28Z
Lists: pgsql-hackers
Andy Fan <zhihui.fan1213@gmail.com> writes: > On Thu, Aug 6, 2020 at 2:22 AM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> In the longer term, it's annoying that we have no test methodology >> for this other than "manually set a breakpoint here". > One of the methods I see is we can just add some GUC variable for some > action injection. basically it adds some code based on the GUC like this; See my straw-man proposal downthread. I'm not very excited about putting things like this into the standard build, because it's really hard to be sure that there are no security-hazard-ish downsides of putting in ways to get at testing behaviors from standard SQL. And then there's the question of whether you're adding noticeable overhead to production builds. So a loadable module that can use some existing hook to provide the needed behavior seems like a better plan to me, whenever we can do it that way. In general, though, it seems like we've seldom regretted investments in test tooling. regards, tom lane
Commits
-
Support testing of cases where table schemas change after planning.
- 6f0b632f083b 14.0 landed
-
Fix matching of sub-partitions when a partitioned plan is stale.
- f992da210ff8 12.4 landed
- c43a36fa8fff 13.0 landed
- 7a980dfc6c15 14.0 landed
-
Speed up planning when partitions can be pruned at plan time.
- 428b260f87e8 12.0 cited
-
Allow ATTACH PARTITION with only ShareUpdateExclusiveLock.
- 898e5e3290a7 12.0 cited