Horton

Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)

torikoshia <torikoshia@oss.nttdata.com>

View thread
From: torikoshia <torikoshia@oss.nttdata.com>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: jian he <jian.universality@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, vignesh21@gmail.com, lena.ribackina@yandex.ru, dam.bel07@gmail.com, zhihuifan1213@163.com, daniel@yesql.se, pgsql-hackers@postgresql.org, andres@anarazel.de, anisimow.d@gmail.com, HukuToc@gmail.com, pgsql-hackers@lists.postgresql.org, a.lepikhov@postgrespro.ru
Date: 2024-01-19T14:26:25Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. doc: Fix COPY ON_ERROR option syntax synopsis.

  2. Disallow specifying ON_ERROR option without value.

  3. Rename COPY option from SAVE_ERROR_TO to ON_ERROR

  4. Fix spelling in notice

  5. Add new COPY option SAVE_ERROR_TO

On 2024-01-19 22:27, Alexander Korotkov wrote:
> Hi!
> 
> On Fri, Jan 19, 2024 at 2:37 PM torikoshia <torikoshia@oss.nttdata.com> 
> wrote:
>> Thanks for making the patch!
> 
> The patch is pushed!  The proposed changes are incorporated excluding 
> this.
> 
>> > -                       /* If SAVE_ERROR_TO is specified, skip rows
>> > with soft errors */
>> > +                       /* If ON_ERROR is specified with IGNORE, skip
>> > rows with soft errors */
>> 
>> This is correct now, but considering future works which add other
>> options like "file 'copy.log'" and
>> "table 'copy_log'", it may be better not to limit the case to 
>> 'IGNORE'.
>> How about something like this?
>> 
>>    If ON_ERROR is specified and the value is not STOP, skip rows with
>> soft errors
> 
> I think when we have more options, then we wouldn't just skip rows
> with soft errors but rather save them.  So, I left this comment as is
> for now.

Agreed.
Thanks for the notification!

> 
> ------
> Regards,
> Alexander Korotkov

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA Group Corporation