Horton

Re: Naming of gss_accept_deleg

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Abhijit Menon-Sen <ams@toroid.org>
Cc: Nathan Bossart <nathandbossart@gmail.com>, Bruce Momjian <bruce@momjian.us>, Stephen Frost <sfrost@snowman.net>, pgsql-hackers@postgresql.org
Date: 2023-05-21T14:57:38Z
Lists: pgsql-hackers 
Abhijit Menon-Sen <ams@toroid.org> writes:
> At 2023-05-20 23:21:57 -0400, tgl@sss.pgh.pa.us wrote:
>> I thought the plan was to also rename the libpq "gssdeleg" connection
>> parameter and so on?  I can look into that tomorrow, if nobody beats
>> me to it.

> I was trying the change to see if it would be better to name it
> "gssdelegate" instead (as in delegate on one side, and accept the
> delegation on the other), but decided that "gssdelegation=enable"
> reads better than "gssdelegate=enable".

Yeah, agreed.

> Here's the diff.

Thanks for doing that legwork!  I found a couple other places where
"deleg" had escaped notice, and changed the lot.  Watching the
buildfarm now ...

			regards, tom lane

Commits

  1. Spell the values of libpq's gssdelegation parameter as "0" and "1".

  2. Expand some more uses of "deleg" to "delegation" or "delegated".

  3. Fix remaining references to gss_accept_deleg.

  4. rename "gss_accept_deleg" to "gss_accept_delegation".