Horton

Re: Removing unneeded self joins

Pogosyan Vardan <vardan.pogosyn@yandex.ru>

View thread
From: Вардан Погосян <vardan.pogosyn@yandex.ru>
To: Andrei Lepikhov <lepihov@gmail.com>, jian he <jian.universality@gmail.com>
Cc: Alexander Korotkov <aekorotkov@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Andrei Lepikhov <a.lepikhov@postgrespro.ru>, Richard Guo <guofenglinux@gmail.com>, Alexander Lakhin <exclusion@gmail.com>, "Gregory Stark (as CFM)" <stark.cfm@gmail.com>, Michał Kłeczek <michal@kleczek.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-07-16T14:26:40Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove GUC_NOT_IN_SAMPLE from enable_self_join_elimination

  2. Put enable_self_join_elimination into postgresql.conf.sample

  3. Get rid of ojrelid local variable in remove_rel_from_query()

  4. Implement Self-Join Elimination

  5. Revert: Remove useless self-joins

  6. Replace lateral references to removed rels in subqueries

  7. Replace relids in lateral subquery parse tree during SJE

  8. Forbid SJE with result relation

  9. Fix misuse of RelOptInfo.unique_for_rels cache by SJE

  10. Replace the relid in some missing fields during SJE

  11. Revert 56-bit relfilenode change and follow-up commits.

  12. Stabilize timetz test across DST transitions.

  13. Speed up finding EquivalenceClasses for a given set of rels

  14. Fix mark-and-restore-skipping test case to not be a self-join.

Attachments

<div><div><div>Hi!</div><div> </div><div>I did the SJE testing at Andrey's request.</div><div>To do this, I used the automatic testing tool EET (Equivalent Expression Transformation) [1] with some modifications. </div><div>EET transforms the logical conditions in a query, creating multiple queries waiting for the same number of rows.</div><div> </div><div>In order to make sure that the SJE logic is executed at all, I tried to cover the code with ereports() as much as possible.</div><div>During the testing process, I did not find any inconsistencies in the number of rows returned, as well as other critical problems.</div></div><div> </div><div> </div><div><div>[1] <a href="https://github.com/JZuming/EET" rel="noopener noreferrer" target="_blank">https://github.com/JZuming/EET</a></div><div> </div></div></div><div>-- </div><div>Regards,</div><div>Vardan Pogosyan</div><div> </div>