Re: patch for check constraints using multiple inheritance

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Henk Enting <h.d.enting@mgrid.net>, pgsql-hackers@postgresql.org
Date: 2010-07-30T14:11:00Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, Jul 29, 2010 at 6:57 AM, Henk Enting <h.d.enting@mgrid.net> wrote:
>> We ran into a problem on 9.0beta3 with check constraints using table
>> inheritance in a multi-level hierarchy with multiple inheritance.

> Thanks for the report.  This bug also appears to exist in 8.4; I'm not
> sure yet how far back it goes.  I'm not so sure your proposed patch is
> the right fix, though; it seems like it ought to be the job of
> AddRelationNewConstraints() and MergeWithExistingConstraint() to make
> sure that the right thing happens, here.

The original design idea was that coninhcount/conislocal would act
exactly like attinhcount/attislocal do for multiply-inherited columns.
Where did we fail to copy that logic?

			regards, tom lane