Horton

Re: pgbench client-side performance issue on large scripts

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Daniel Verite" <daniel@manitou-mail.org>
Cc: pgsql-hackers@postgresql.org
Date: 2025-02-27T16:00:22Z
Lists: pgsql-hackers 
"Daniel Verite" <daniel@manitou-mail.org> writes:
> 	Tom Lane wrote:
>> I got nerd-sniped by this question and spent some time looking into
>> it.

> Thank you for the patch! LGTM.

Thanks for reviewing!  Pushed after a tiny bit more polishing.

			regards, tom lane

Commits

  1. Avoid unnecessary computation of pgbench's script line number.

  2. Get rid of O(N^2) script-parsing overhead in pgbench.