Re: meson PGXS compatibility
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Nazir Bilal Yavuz <byavuz81@gmail.com>,
Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Date: 2022-10-05T20:20:22Z
Lists: pgsql-hackers
Andres Freund <andres@anarazel.de> writes: > On macOS we ran ranlib after installing a static library. This was added a > long time ago, in 58ad65ec2def. I cannot reproduce an issue in more recent > macOS versions. I agree that shouldn't be necessary anymore (and if it is, we'll find out soon enough). > I'm on the fence about removing the "touch $@" from the rule building static > libs. That was added because of macos's ranlib not setting fine-grained > timestamps. On a modern mac ar and ranlib are the same binary, and maybe > that means that ar has the same issue? Both do set fine-grained > timestamps: Please see the commit message for 826eff57c4c: the issue seems to arise only with specific combinations of software, in particular with non-Apple versions of "make" (although maybe later Apple builds have fixed make's failure to read sub-second timestamps?). That's a relatively recent hack, and I'm very hesitant to conclude that we don't need it anymore just because you failed to reproduce an issue locally. It very possibly isn't a problem in a meson build, though, depending on how much meson depends on file timestamps. regards, tom lane
Commits
-
meson: Add basic PGXS compatibility
- 5bdd0cfb9103 16.0 landed
-
autoconf: Move export_dynamic determination to configure
- 9db49fc5bfdc 16.0 landed
-
autoconf: Don't AC_SUBST() LD in configure
- 069de07eae73 16.0 landed
-
autoconf: Unify CFLAGS_SSE42 and CFLAGS_ARMV8_CRC32C
- e0f0e08e17a6 16.0 landed
-
autoconf: Rely on ar supporting index creation
- 2473cb9ff374 16.0 landed