Horton

Re: Fix typos and inconsistencies for v16

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-04-18T02:11:09Z
Lists: pgsql-hackers 
David Rowley <dgrowleyml@gmail.com> writes:
> On Tue, 18 Apr 2023 at 06:00, Alexander Lakhin <exclusion@gmail.com> wrote:
>> Also, maybe OID_MAX should be removed from src/include/postgres_ext.h as it's unused since eb8312a22.

> I didn't touch this. It seems like it could be useful for extensions
> and client apps even if it's not used in core.

Agreed, bad idea.  For better or worse, that's part of our client API now.

>> Beside that, this simple script:
>> for w in $(cat src/tools/pgindent/typedefs.list); do grep -q -P "\b$w\b" -r * --exclude typedefs.list || echo "$w"; done
>> detects 58 identifiers that don't exist in the source tree anymore (see typedefs.lost attached).
>> Maybe they should be removed from typedefs.list too.

> I didn't touch this either.  typedefs.list normally gets some work
> done during the pgindent run, which is likely going to happen around
> May or June.

Yeah, it will get refreshed from the buildfarm output [1] pretty soon.
A quick check says that as of today, that refresh would add 81 names
and remove 94.  (Seems like a remarkably high number of removals,
but I didn't dig further than counting the diff output.)

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/typedefs.pl?show_list

Commits

  1. Fix typo with wait event for SLRU buffer of commit timestamps

  2. Fix typos in comments

  3. doc: Fix typo in pg_amcheck for term "schema"

  4. Remove unused global variable

  5. Fix incorrect function name reference

  6. Fix various typos and incorrect/outdated name references

  7. Fix some typos and some incorrectly duplicated words

  8. Fix various typos

  9. Improve GIN cost estimation

  10. Refactor LogicalTapeSet/LogicalTape interface.

  11. Refactor sharedfileset.c to separate out fileset implementation.

  12. Multirange datatypes

  13. Copy editing: fix a bunch of misspellings and poor wording.

  14. Implement operator class parameters

  15. Various improvements of skipping index scan during vacuum technics