Horton
Menu

Thread

  1. Correction to comment of brin_range_deserialize

    ji xu <thanksgreed@gmail.com> — 2026-01-28T08:10:49Z

    Hi Hackers,

I found an issue in the comments of the
src/backend/access/brin/brin_minmax_multi.c file.

The header comment of function brin_range_deserialize currently reads:
"Serialize the in-memory representation into a compact varlena value."

which looks like a copy/paste error, where "Serialize" should be
"Deserialize".

I'm posting this patch to fix the comment.

Regards,
ji xu

  2. Re: Correction to comment of brin_range_deserialize

    Chao Li <li.evan.chao@gmail.com> — 2026-01-28T23:13:44Z

    
> On Jan 28, 2026, at 16:10, ji xu <thanksgreed@gmail.com> wrote:
> 
> Hi Hackers,
> 
> I found an issue in the comments of the  src/backend/access/brin/brin_minmax_multi.c file.
> 
> The header comment of function brin_range_deserialize currently reads:
> "Serialize the in-memory representation into a compact varlena value."
> 
> which looks like a copy/paste error, where "Serialize" should be "Deserialize".
> 
> I'm posting this patch to fix the comment.
> 
> Regards,
> ji xu
> <v1-0001-Correction-to-comment-of-brin_range_deserialize.patch>

Indeed, like a copy-pasto from the initial commit (ab59610) where the 2 functions (serialize/deserialize) were added.

The updated comment in the patch looks good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

  3. Re: Correction to comment of brin_range_deserialize

    Michael Paquier <michael@paquier.xyz> — 2026-01-29T00:22:20Z

    On Thu, Jan 29, 2026 at 07:13:44AM +0800, Chao Li wrote:
> Indeed, like a copy-pasto from the initial commit (ab59610) where
> the 2 functions (serialize/deserialize) were added.
> 
> The updated comment in the patch looks good to me.

Clearly a copy-pasto.  I've picked up that for later, thanks for the
report.
--
Michael