Re: [PATCH] Expand character set for ltree labels
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Garen Torikian <gjtorikian@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2022-10-05T18:59:01Z
Lists: pgsql-hackers
Garen Torikian <gjtorikian@gmail.com> writes: > I am submitting a patch to expand the label requirements for ltree. > The current format is restricted to alphanumeric characters, plus _. > Unfortunately, for non-English labels, this set is insufficient. Hm? Perhaps the docs are a bit unclear about that, but it's not restricted to ASCII alphanumerics. AFAICS the code will accept whatever iswalpha() and iswdigit() will accept in the database's default locale. There's certainly work that could/should be done to allow use of not-so-default locales, but that's not specific to ltree. I'm not sure that doing an application-side encoding is attractive compared to just using that ability directly. If you do want to do application-side encoding, I'm unsure why punycode would be the choice anyway, as opposed to something that can fit in the existing restrictions. > On top of this, I added support for two more characters: # and ;, which are > used for HTML entities. That seems really pretty random. regards, tom lane
Commits
-
Allow hyphens in ltree labels
- b1665bf01e5f 16.0 landed
-
Check that xmax didn't commit in freeze check.
- eb5ad4ff05fd 16.0 cited
-
Push lpp variable closer to usage in heapgetpage()
- e351f8541831 16.0 cited
-
tests: Restrict pg_locks queries in advisory_locks.sql to current database
- c3315a7da57b 16.0 cited