Re: Allow wal_keep_segments to keep all segments

Bruce Momjian <bruce@momjian.us> writes:
> Heikki Linnakangas wrote:
>> Surely we don't expect DBAs to delete old files in pg_xlog? I agree with 
>> Simon here, I think it would be better to not provide -1 as an option 
>> here. At least you better document well that you should only do that 
>> temporarily or you will eventually run out of disk space.

> I have updated the doc text to mention "temporarily" everywhere '-1' is
> mentioned.

FWIW, I've come to agree with Simon.  Allowing -1 doesn't do anything
that you can't do with a large positive setting, and what it does do
is to encourage people to set the variable to an unsafe value as a
substitute for thinking.

			regards, tom lane