Re: Emacs vs pg_indent's weird indentation for function declarations

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Piotr Stefaniak <postgres@piotr-stefaniak.me>
Cc: Thomas Munro <thomas.munro@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>, Michael Paquier <michael@paquier.xyz>
Date: 2019-05-19T18:13:09Z
Lists: pgsql-hackers
Piotr Stefaniak <postgres@piotr-stefaniak.me> writes:
> On 19/05/2019 19.27, Tom Lane wrote:
>> Piotr Stefaniak <postgres@piotr-stefaniak.me> writes:
>>> I think it's safe to assume that upstream can drop support for K&R-style
>>> parameters altogether.

>> Cool.  I already created the switch, but maybe we could have it
>> default to -nkr?

> Sorry, but GNU indent already uses -kr for something else and I would 
> like FreeBSD indent have something like that under the same name. 
> Besides, indent has too many options and this one doesn't look like 
> particularly desired by anyone. It's possible that someone will complain 
> some day, but I don't think we should assume that they'll do or that 
> they're more important than the other users who benefit from your change 
> being the default behavior and no additional options.

Huh.  OK, I'll rip the switch back out again.

			regards, tom lane



Commits

  1. Phase 2 pgindent run for v12.

  2. ANSI-ify a few straggler K&R-style function definitions.