Horton

Re: Add ENCODING option to COPY

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Hitoshi Harada <umi.tanuki@gmail.com>
Cc: Itagaki Takahiro <itagaki.takahiro@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-02-04T16:52:04Z
Lists: pgsql-hackers 
Hitoshi Harada <umi.tanuki@gmail.com> writes:
> 2011/2/5 Tom Lane <tgl@sss.pgh.pa.us>:
>> Yeah, putting backend-only stuff into that header is a nonstarter.

> Do you mean you think it' all right to define
> pg_cached_encoding_conversion() in pg_conversion_fn.h?

That seems pretty random too.  I still think you've designed this API
badly and it'd be better to avoid exposing the FmgrInfo to callers
by letting the function manage the cache internally.

			regards, tom lane