Horton

Re: Unused parameters & co in code

Antonin Houska <ah@cybertec.at>

View thread View on postgr.es
From: Antonin Houska <ah@cybertec.at>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-01-31T09:15:21Z
Lists: pgsql-hackers 
Michael Paquier <michael@paquier.xyz> wrote:

> Hi all,
> 
> I just got a run with CFLAGS with the following options:
> -Wunused-function -Wunused-variable -Wunused-const-variable
>  -Wno-unused-result -Wunused-parameter -Wunused-macros
> 
> And while this generates a lot of noise for callbacks and depending on
> the environment used, this is also pointing to things which could be
> simplified:

This reminds me that I reported some unused arguments too:

https://www.postgresql.org/message-id/6702.1473067599@localhost

SnapBuildBuildSnapshot() was fixed in commit 6c2003f8a1b, but the other two
are still there.

-- 
Antonin Houska
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26, A-2700 Wiener Neustadt
Web: https://www.cybertec-postgresql.com

Commits

  1. Simplify some code in pg_rewind when syncing target directory

  2. Don't force-assign transaction id when exporting a snapshot.