Horton

Re: pgbench error: (setshell) of script 0; execution of meta-command failed

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Andy Fan <zhihuifan1213@163.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-01-10T15:20:51Z
Lists: pgsql-hackers 
I wrote:
> Since legacy-pqsignal is really not supposed to be used by clients
> anymore, maybe we could just adjust it to set SA_RESTART for SIGALRM?
> The other alternatives I can think of amount to re-introducing
> link order dependencies, which would be horrid.

Actually, after re-reading the thread that led to 06843df4a [1],
I think a better idea is to introduce some macro magic to force
frontend clients to use libpgport's version of pqsignal() instead
of the one from libpq.  We mustn't change the real name of libpq's
version, but I think we could get away with that for libpgport.

I'm a bit tied up today, but can look at this over the weekend if
nobody beats me to it.

			regards, tom lane

[1] https://www.postgresql.org/message-id/flat/467042.1695766998%40sss.pgh.pa.us

Commits

  1. Avoid symbol collisions between pqsignal.c and legacy-pqsignal.c.

  2. Suppress macOS warnings about duplicate libraries in link commands.