Re: longfin missing gssapi_ext.h
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
Cc: "Jonathan S. Katz" <jkatz@postgresql.org>,
Thomas Munro <thomas.munro@gmail.com>,
pgsql-hackers@lists.postgresql.org,
Amit Kapila <amit.kapila16@gmail.com>,
Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2023-04-17T14:30:14Z
Lists: pgsql-hackers
Stephen Frost <sfrost@snowman.net> writes: > I'm guessing it's not really an issue but it does make changing > configure a bit annoying on my Ubuntu 22.04, when I run autoconf2.69, I > end up with this additional hunk as changed from what our configure > currently has. Not surprising. Thanks to autoconf's long release cycles, individual distros often are carrying local patches that affect its output. To ensure consistent results across committers, our policy is that you should use built-from-upstream-source autoconf not a vendor's version. (In principle that could bite us sometime, but it hasn't yet.) Also, you should generally run autoheader after autoconf. Checking things here, I notice that pg_config.h.in hasn't been updated for the last few gssapi-related commits: $ git diff diff --git a/src/include/pg_config.h.in b/src/include/pg_config.h.in index 3665e79..6d572c3 100644 *** a/src/include/pg_config.h.in --- b/src/include/pg_config.h.in *************** *** 196,201 **** --- 196,207 ---- /* Define to 1 if you have the `getpeerucred' function. */ #undef HAVE_GETPEERUCRED + /* Define to 1 if you have the <gssapi_ext.h> header file. */ + #undef HAVE_GSSAPI_EXT_H + + /* Define to 1 if you have the <gssapi/gssapi_ext.h> header file. */ + #undef HAVE_GSSAPI_GSSAPI_EXT_H + /* Define to 1 if you have the <gssapi/gssapi.h> header file. */ #undef HAVE_GSSAPI_GSSAPI_H Shall I push that, or do you want to? regards, tom lane
Commits
-
Further cleanup of autoconf output files for GSSAPI changes.
- d48ac0070cff 16.0 landed
-
Update Kerberos/GSSAPI configure/meson check
- 1c52f9c042fb 16.0 landed
-
Explicitly require MIT Kerberos for GSSAPI
- f7431bca8b01 16.0 landed
-
De-Revert "Add support for Kerberos credential delegation"
- 6633cfb21691 16.0 landed
-
Revert "Add support for Kerberos credential delegation"
- 3d03b24c350a 16.0 landed