Re: [PATCH] New [relation] option engine

Nikolay Shaplov <dhyan@nataraj.su>

From: Nikolay Shaplov <dhyan@nataraj.su>
To: jian he <jian.universality@gmail.com>, pgsql-hackers@lists.postgresql.org
Cc: Peter Smith <smithpb2250@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Yura Sokolov <y.sokolov@postgrespro.ru>, pgsql-hackers@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>, Nikolay Shaplov <dhyan@nataraj.su>
Date: 2024-06-22T18:21:08Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Tighten test_predtest's input checks, and improve error messages.

  2. Avoid reference to nonexistent array element in ExecInitAgg().

  3. Clean up newlines following left parentheses

Attachments

While fixing the patch according to jian he recommendations, I come to a 
conclusion that using void* pointer to a structure is really bad idea. Do not 
know why I ever did it that way from start.
So I fixed it.
Changes of this fix can be seen here: 
https://gitlab.com/dhyannataraj/postgres/-/commit/be4d9e16

The whole patch is attached to this mail.

-- 
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su