Horton

Re: pg_validatebackup -> pg_verifybackup?

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: David Steele <david@pgmasters.net>, Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Date: 2020-04-10T21:23:58Z
Lists: pgsql-hackers 
Andres Freund <andres@anarazel.de> writes:
> On 2020-04-10 16:40:02 -0400, Tom Lane wrote:
>> It doesn't really seem like either name is problematic from that
>> standpoint?  "Verify backup" isn't prejudging what aspect of the
>> backup is going to be verified, AFAICS.

> My point is that I'd eventually like to see the same tool also be usable
> to just verify the checksums of a normal, non-backup, data directory.

Meh.  I would argue that that's an actively BAD idea.  The use-cases
are entirely different, the implementation is going to be quite a lot
different, the relevant options are going to be quite a lot different.
It will not be better for either implementors or users to force those
into the same executable.

			regards, tom lane

Commits

  1. Rename pg_validatebackup to pg_verifybackup some more.

  2. Rename pg_validatebackup to pg_verifybackup.