Re: sslinfo extension - add notbefore and notafter timestamps

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: Jacob Champion <jacob.champion@enterprisedb.com>

Cc: Cary Huang <cary.huang@highgo.ca>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2024-03-22T13:14:57Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add notBefore and notAfter to SSL cert info display
- 6acb0a628ecc 17.0 landed
- 75ec5e7bec70 17.0 landed
Set fixed dates for test certificates validity
- 40fad96530ca 17.0 landed

Attachments

v12-0001-Add-notBefore-and-notAfter-to-SSL-cert-info-disp.patch (application/octet-stream) patch v12-0001

> On 20 Mar 2024, at 17:32, Jacob Champion <jacob.champion@enterprisedb.com> wrote:

> I can't find anything else to note; patch LGTM.

While staging this to commit I realized one silly thing about it warranting
another round here.  The ASN.1 timediff code can diff against *any* timestamp,
not just the UNIX epoch, so we could just pass in the postgres epoch and skip
the final subtraction since we're already correctly adjusted.  This removes the
non-overflow checked arithmetic with a simpler logic.

--
Daniel Gustafsson