Horton

Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2025-08-18T01:26:22Z
Lists: pgsql-hackers 
David Rowley <dgrowleyml@gmail.com> writes:
> On Mon, 18 Aug 2025 at 13:10, Michael Paquier <michael@paquier.xyz> wrote:
>> If we do that, I guess that we could just remove HASH_DEBUG, keeping
>> only HASH_STATISTICS.

> I wondered about that and thought that there might be an above zero
> chance that someone would want HASH_DEBUG without USE_ASSERT_CHECKING.
> I don't really know if that person exists. It certainly isn't me.

Yeah, it's really quite unclear what the existing HASH_DEBUG printout
is good for.  At least in our usage, it doesn't tell you anything
you can't discover from static code analysis.  I'm +1 for just
dropping it altogether.

			regards, tom lane

Commits

  1. Remove HASH_DEBUG output from dynahash.c

  2. Use elog(DEBUG4) for dynahash.c statistics output

  3. Fix invalid format string in HASH_DEBUG code

  4. Fix failing -D HASH_STATISTICS builds

  5. Refactor initial hash lookup in dynahash.c

  6. Remove large fill factor support from dynahash.c.

  7. Remove broken and useless entry-count printing in HASH_DEBUG code.

  8. Partition the freelist for shared dynahash tables.