Horton

Re: Cannot find a working 64-bit integer type on Illumos

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Tomas Vondra <tomas@vondra.me>, Peter Eisentraut <peter@eisentraut.org>, Heikki Linnakangas <hlinnaka@iki.fi>, Japin Li <japinli@hotmail.com>, Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-12-04T21:50:05Z
Lists: pgsql-hackers 
Thomas Munro <thomas.munro@gmail.com> writes:
> On Thu, Dec 5, 2024 at 10:20 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Another rather serious problem here is that we no longer provide
>> macro PG_INT64_TYPE, which seems rather likely to break applications
>> that were relying on it.  That is part of our external API, we
>> can't just remove it on a whim.

> I had concluded that PG_INT64_TYPE wasn't part of our external API but
> pg_int64 was, based on the comment:

>  /* Define a signed 64-bit integer type for use in client API declarations. */
> -typedef PG_INT64_TYPE pg_int64;
> +typedef int64_t pg_int64;

Oh, hmm, maybe so.  OTOH, that typedef breaks the idea of #define'ing
PG_INT64_TYPE as int64_t.  We need this header to be readable without
any prior system headers, so I'm afraid we're all the way back to
making configure derive the name of a 64-bit type.

			regards, tom lane

Commits

  1. Move pg_int64 back to postgres_ext.h

  2. pgbench: Make set_random_seed() 64-bit everywhere.

  3. Use PRI?64 instead of "ll?" in format strings (continued).

  4. Fix order of -I switches for building pg_regress.o.

  5. libpq: Deprecate pg_int64.

  6. Use PRI*64 instead of "ll*" in format strings (minimal trial)

  7. Fix header inclusion order in c.h.

  8. Use <stdint.h> and <inttypes.h> for c.h integers.

  9. Remove traces of BeOS.

  10. More correct way to check for existence of types, which allows to specify