Horton

Re: A Japanese-unfriendy error message contruction

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: pgsql-hackers@postgresql.org
Date: 2018-05-24T18:20:21Z
Lists: pgsql-hackers 
Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes:
> Hello. Here is the patch set.

Thanks!  I pushed all this plus fixes for the OCLASS_PUBLICATION_REL
code.

The only non-cosmetic change I made was that I didn't much like what
you'd done with the OCLASS_DEFACL code: it seemed quite confusing to
be renaming buffers like that, plus it was still assuming more than
I thought it should about how the message would go together in the end.
I took the advice of the manual instead, and just made pairs of
near-duplicate messages to be translated separately.

I'm still not sure whether the OCLASS_DEFAULT case is satisfactorily
translatable.  It would not take a lot more code to expand its message to
"default value for column %s of %s", where the second %s is the result of
getRelationDescription.  However, I have no idea whether there are any
translations where that would really work noticeably better.

			regards, tom lane

Commits

  1. Improve English wording of some other getObjectDescription() messages.

  2. Improve translatability of some getObjectDescription() messages.

  3. Fix objectaddress.c code for publication relations.

  4. Properly schema-qualify additional object types in getObjectDescription().