Re: jsonpath: Inconsistency of timestamp_tz() Output

David E. Wheeler <david@justatheory.com>

From: "David E. Wheeler" <david@justatheory.com>

To: Jeevan Chalke <jeevan.chalke@enterprisedb.com>

Cc: Junwang Zhao <zhjwpku@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2024-07-22T17:29:02Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix comment in libpqrcv_check_conninfo().
- 629520be5f9d 18.0 cited
Remove useless extern keywords
- 3fb59e789dd9 18.0 cited

Attachments

v5-0001-Preserve-tz-when-converting-to-jsonb-timestamptz.patch (application/octet-stream) patch v5-0001
(unnamed) (text/plain)

On Jul 22, 2024, at 03:12, Jeevan Chalke <jeevan.chalke@enterprisedb.com> wrote:

> I agree with David that we need to set the tz explicitly as the JsonbValue struct maintains that separately.
> 
> However, in the attached version, I have added some comments and also, fixed some indentation.

Thank you for the review. I changed a single word in your comments (which are welcome). Thank you!

Just to reiterate, this is not an ideal fix, as the `date_timestamptz` and `timestamp_timestamptz` perform the same calculations. It would be nice to do it only once.

Best,

David