Re: recovery test failures on hoverfly
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Michael Paquier <michael@paquier.xyz>,
Amit Kapila <amit.kapila16@gmail.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
Noah Misch <noah@leadboat.com>
Date: 2021-06-12T21:28:19Z
Lists: pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes: > I'm a bit dubious about this. It doesn't seem more robust to insist that > we pass undef in certain cases. True, it'd be nicer if that didn't matter; mainly because people will get it wrong in future. > If passing the SQL via stdin is fragile, > as we also found to be the case with passing it via the command line, > perhaps we should try passing it via a tmp file. Then there would > presumably be no SIGPIPE. Seems kind of inefficient. Maybe writing and reading a file would be a negligible cost compared to everything else involved, but I'm not sure. Another angle is that the SIGPIPE complaints aren't necessarily a bad thing: if psql doesn't read what we send, it's good to know about that. IMO the real problem is that the errors are so darn nonrepeatable. I wonder if there is a way to make them more reproducible? regards, tom lane
Commits
-
Restore robustness of TAP tests that wait for postmaster restart.
- f452aaf7d4a9 14.0 landed
- b170ca021c6a 11.13 landed
- 94e21021cdf2 13.4 landed
- 1b48dd50abd6 10.18 landed
- 0b619df6daca 12.8 landed