Horton
Menu

Re: Re: [HACKERS] Patch für MAP_HUGETLB for mmap() shared memory

Christian Kruse <cjk+postgres@defunct.ch>

View thread
From: Christian Kruse <cjk+postgres@defunct.ch>
To: pgsql-hackers@postgresql.org
Date: 2012-10-30T22:10:44Z
Lists: pgsql-hackers 
Hey,

On Tuesday 30 October 2012 20:33:18 Andres Freund wrote:
> +#ifdef MAP_HUGETLB
> +#  ifdef __ia64__
> +#    define PG_HUGETLB_BASE_ADDR (void *)(0x8000000000000000UL)
> +#    define PG_MAP_HUGETLB (MAP_HUGETLB|MAP_FIXED)
> +#  else
> 
> Not your fault, but that looks rather strange to me. The level of
> documentation around the requirement of using MAP_FIXED is subpar...

Ok, after further reading I think with MAP_FIXED one has to „generate“ SHM 
segment addresses hisself. So 0x8000000000000000UL would just be one possible 
location for a hugepage.

Since this feature is not used in PG for now, the code should work. Could 
someone with access to a ia64 architecture verify it?

Greetings,
 CK

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Give a better error message when trying to change