Re: Support custom socket directory in pg_upgrade
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-11-25T19:36:42Z
Lists: pgsql-hackers
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Add a --socketdir option to pg_upgrade.
- 2d34ad843031 12.0 landed
Daniel Gustafsson <daniel@yesql.se> writes:
> [ pg_upgrade_sockdir-v3.patch ]
BTW, I notice that cfbot doesn't like this now that Thomas is running it
with -Werror:
option.c: In function ‘parseCommandLine’:
option.c:265:8: error: ignoring return value of ‘getcwd’, declared with attribute warn_unused_result [-Werror=unused-result]
getcwd(default_sockdir, MAXPGPATH);
^
cc1: all warnings being treated as errors
Failing to check a syscall's result isn't per project style even if
the tools would let you get away with it. Other places in that same
file do
if (!getcwd(cwd, MAXPGPATH))
pg_fatal("could not determine current directory\n");
regards, tom lane