Re: small fix to possible null pointer dereference in byteaout() varlena.c

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Grzegorz Jaśkiewicz <gryzman@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2010-09-28T15:07:42Z
Lists: pgsql-hackers
=?UTF-8?Q?Grzegorz_Ja=C5=9Bkiewicz?= <gryzman@gmail.com> writes:
> It would crash if input is of unrecognized format. Probably than
> there's going to be more problems to be concerned with, but just in
> case, don't crash in

I'm not sure why you think this is a good change, but it would break
things: in particular, the code would fail to null-terminate the string
in the hex-output case.  Also, the case that you seem to be trying to
defend against can't happen because elog(ERROR) doesn't return.

			regards, tom lane