Horton

Re: pgsql: Add suport for server-side LZ4 base backup compression.

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-02-12T22:16:03Z
Lists: pgsql-hackers 
Robert Haas <robertmhaas@gmail.com> writes:
> On Sat, Feb 12, 2022 at 5:09 PM Andres Freund <andres@anarazel.de> wrote:
>> I don't think there's an actual configure check for the lz4 binary? Looks like
>> a static assignment in src/Makefile.global.in to me.

> Oh. That seems kind of dumb.

It looks to me like somebody figured it didn't need any more support
than gzip/bzip2, which is wrong on a couple of grounds:
* hardly any modern platforms lack those, unlike lz4
* we don't invoke either one of them during testing, only when
  you explicitly ask to make a compressed tarball

I think adding an explicit PGAC_PATH_PROGS would be worth the cycles.

			regards, tom lane

Commits

  1. Remove command checks in tests of pg_basebackup and pg_receivewal

  2. Add ./configure check for "lz4" command

  3. Add suport for server-side LZ4 base backup compression.