Re: cpluspluscheck complains about use of register

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Andres Freund <andres@anarazel.de>

Cc: pgsql-hackers@postgresql.org, Fabien COELHO <coelho@cri.ensmp.fr>

Date: 2022-09-24T20:01:25Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove uses of register due to incompatibility with C++17 and up
- 03bf971d2dc7 16.0 landed

Andres Freund <andres@anarazel.de> writes:
> I hit this again while porting cplupluscheck to be invoked by meson as
> well. ISTM that we should just remove the uses of register.

OK by me.

> I tried to use -Wregister to keep us honest going forward, but unfortunately
> it only works with a C++ compiler...

I think we only really care about stuff that cpluspluscheck would spot,
so I don't feel a need to mess with the standard compilation flags.

			regards, tom lane