Re: Don't overwrite scan key in systable_beginscan()

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2024-08-08T19:28:04Z

Lists: pgsql-hackers

Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, Aug 8, 2024 at 2:46 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>> I propose to fix that by making a copy of the scan keys passed by the
>> caller and make the modifications there.

> This does have the disadvantage of adding more palloc overhead.

It seems hard to believe that one more palloc + memcpy is going to be
noticeable in the context of an index scan.

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix temporary memory leak in system table index scans
- 1acf10549e64 18.0 landed
Don't overwrite scan key in systable_beginscan()
- 811af9786b91 18.0 landed
Replace gratuitous memmove() with memcpy()
- 8b5c6a54c439 18.0 landed