Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock

Greg Burd <greg@burd.me>

From: "Greg Burd" <greg@burd.me>
To: "Andres Freund" <andres@anarazel.de>
Cc: "Thomas Munro" <thomas.munro@gmail.com>, "Tomas Vondra" <tomas@vondra.me>, "PostgreSQL Hackers" <pgsql-hackers@lists.postgresql.org>
Date: 2025-09-05T18:26:06Z
Lists: pgsql-hackers
On Fri, Sep 5, 2025, at 12:27 PM, Andres Freund wrote:
> Hi,
>
> On 2025-09-04 13:24:00 -0400, Greg Burd wrote:
>> On Thu, Sep 4, 2025, at 12:59 PM, Andres Freund wrote:
>> > Hi,
>> >
>> > On 2025-08-27 15:42:48 -0400, Greg Burd wrote:
>> >> Regardless, I feel the first two patches on this set address the
>> >> intention of this thread.
>> >
>> > I'm planning to commit the first two patches after making a pass through
>> > them. I have some work that I'm cleaning up to post that'd conflict and Tomas'
>> > NUMA patches are affected too.
>> 
>> Fantastic, and thank you.  If you have any concerns I'm here to work through
>> them with you.  I'll carry over the idea from the 3rd patch into a new
>> thread.
>
> Committed with very minor changes:
> - removal of StrategyFreeBuffer() prototype
> - the new message in autoprewarm used "autoprewarm: " in the log message,
>   which none of the other messages do - not the prettiest, but it's consistent
>   with what's already there
> - some editing of the commit message
> - some whitespace changes

All reasonable and thoughtful changes.

>
> Greetings,
>
> Andres Freund

thank you.

-greg



Commits

  1. bufmgr: Remove freelist, always use clock-sweep

  2. bufmgr: Use consistent naming of the clock-sweep algorithm