Re: strange error reporting

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Alvaro Herrera <alvherre@alvh.no-ip.org>

Cc: Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2021-01-26T21:45:23Z

Lists: pgsql-hackers

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> pgbench has one occurrence of the old pattern in master, in line 6043.
> However, since doConnect() returns NULL when it gets CONNECTION_BAD,
> that seems dead code.  This patch kills it.

Oh ... I missed that because it wasn't adjacent to the PQconnectdbParams
call :-(.  You're right, that's dead code and we should just delete it.

			regards, tom lane

Commits

pgbench: Remove dead code
- ef2a83323c3b 13.2 landed
- cfbbc1f17c24 9.5.25 landed
- be2729dfaac3 10.16 landed
- 6819b9042fe6 14.0 landed
- 4162f91d1c20 9.6.21 landed
- 30854d94c627 12.6 landed
- 3055e8d0f1e7 11.11 landed
Report the true database name on connection errors
- fdf9d005401d 12.6 landed
- fdd405c63fff 11.11 landed
- f2dc962360b3 9.5.25 landed
- f17e8f33f781 13.2 landed
- bcae842b962a 9.6.21 landed
- 11a708f8159f 10.16 landed
Avoid redundantly prefixing PQerrorMessage for a connection failure.
- 58cd8dca3de0 14.0 landed
Improve new wording of libpq's connection failure messages.
- 27a48e5a16ff 14.0 landed