Re: pg_waldump: add test for coverage

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>
To: Dong Wook Lee <sh95119@gmail.com>, pgsql-hackers@postgresql.org
Date: 2023-06-14T07:16:50Z
Lists: pgsql-hackers

Attachments

On 06.09.22 07:57, Peter Eisentraut wrote:
>> I wrote a test for coverage.
>> Unfortunately, it seems to take quite a while to run the test.
>> I want to improve these execution times, but I don't know exactly what 
>> to do.
>> Therefore, I want to hear feedback from many people.

> I think having some more test coverage for pg_waldump would be good, so 
> I encourage you to continue working on this.

I made an updated patch that incorporates many of your ideas and code, 
just made it a bit more compact, and added more tests for various 
command-line options.  This moves the test coverage of pg_waldump from 
"bloodbath" to "mixed fruit salad", which I think is pretty good 
progress.  And now there is room for additional patches if someone wants 
to figure out, e.g., how to get more complete coverage in gindesc.c or 
whatever.

Commits

  1. pg_waldump: Add test case for notice message

  2. pg_waldump: Add more tests