Re: [COMMITTERS] pgsql: Mark JSON error detail messages for translation.
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@2ndquadrant.com>, pgsql-hackers@postgresql.org, Alvaro Herrera <alvherre@commandprompt.com>
Date: 2012-06-13T23:49:07Z
Lists: pgsql-hackers
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Mark JSON error detail messages for translation.
- 36b7e3da17bc 9.2.0 cited
Robert Haas <robertmhaas@gmail.com> writes: >>> ! DETAIL: Character with value 0x0a must be escaped. >>> ! CONTEXT: JSON data, line 1: "abc >>> ! ... >>> >>> This seems an odd way to present this, especially if the goal is to >>> NOT include the character needing escaping in the log unescaped, which >>> I thought was the point of saying 0x0a. I thought of a simple way to address that objection for this particular case: we can just truncate the context display *at* the offending character, instead of *after* it. This is playing a bit fast and loose with the general principle that the context should end at the point of detection of the error; but given that the character in question is always unprintable, I think it's probably not going to bother anyone. I've gone ahead and committed this before branching, though I'm certainly still willing to entertain suggestions for further improvement. regards, tom lane