Re: [PATCH] Add some documentation on how to call internal functions

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Florents Tselai <florents.tselai@gmail.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-01-17T19:39:32Z
Lists: pgsql-hackers
Pavel Stehule <pavel.stehule@gmail.com> writes:
> pá 18. 10. 2024 v 22:23 odesílatel Tom Lane <tgl@sss.pgh.pa.us> napsal:
>> The problem here is that we failed to pass through the result of
>> PG_GET_COLLATION() to text_starts_with.  We could do that, certainly,
>> for a couple more lines of code.  But it feels like this is getting
>> into details that obscure the main point.  I wonder if it'd be better
>> to choose a different example that calls a non-collation-dependent
>> target function.

> This can be a trap for some beginners too. So example of
> DirectFunctionCall2Coll can be nice

Hearing no other comments, I fixed the example to pass through
collation and pushed it.

			regards, tom lane



Commits

  1. Add documentation about calling version-1 C functions from C.