Re: partitioned indexes and tablespaces
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
Michael Paquier <michael@paquier.xyz>,
Robert Haas <robertmhaas@gmail.com>,
Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2018-11-03T19:32:03Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes: > On 2018-Nov-03, Andrew Dunstan wrote: >> +1. This is unquestionably a POLA violation that should be fixed, IMNSHO. > Yeah, that's my view on it too. > Pushed. Hmm ... in the April thread, one of the main concerns that prevented hasty action was fear of breaking dump/restore behavior. Have you checked that with this change, a dump/restore will restore the same state (same actual tablespace assignments) that existed in the source DB? How about if the parent partitioned index's tablespace assignment has been changed since a child index was made? What happens with the --no-tablespaces option? I think I'm okay with this change if the answers to all those questions are sane, but I didn't see them discussed in this thread. regards, tom lane
Commits
-
Fix tablespace handling for partitioned indexes
- 33e6c34c3267 11.1 landed
- dfa608141982 12.0 landed