Horton

Re: Cleanup isolation specs from unused steps

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-08-19T15:02:42Z
Lists: pgsql-hackers 
Michael Paquier <michael@paquier.xyz> writes:
> I have been looking at the isolation tests, and we have in some specs
> steps which are defined but not used in any permutations.

Hmm, might any of those represent actual bugs?  Or are they just
leftovers from test development?

> In order to
> detect them, I have been using the attached trick to track which
> permutations are used.  This allows to find immediately any
> over-engineered spec by generating diffs about steps defined by not
> used in any permutations.  On HEAD, we have six specs entering in this
> category.

Seems like a good idea; I'm surprised we've got so many cases.

			regards, tom lane

Commits

  1. Detect unused steps in isolation specs and do some cleanup

  2. Remove dry-run mode from isolationtester