Re: Sometimes the output to the stdout in Windows disappears
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Victor Spirin <v.spirin@postgrespro.ru>,
pgsql-hackers@lists.postgresql.org
Date: 2020-10-18T18:33:14Z
Lists: pgsql-hackers
Alexander Lakhin <exclusion@gmail.com> writes: > I've made a simple cmd script to reproduce problems seen on dory: > ... > Without the fix I've got errors on iterations 43, 46, 128, 47, 14, 4, > 27, which approximately corresponds to the ECPG-Check failure frequency > on dory (for HEAD). > With the fix all the 200 iterations passed as expected. > Then I ran the loop again just to be sure and got: > test thread/descriptor ... stderr FAILED 81 ms > iteration 124 failed. I had been thinking we'd have to wait a month or two for the buildfarm to accumulate enough runs to be confident in whether the WSACleanup removal fixes the ecpg failures. However, now that you did this experiment, I think we have enough evidence already that it fixes it (or at least makes things an order of magnitude better). So now I'm inclined to not wait, but go ahead and backpatch 7d00a6b2d now. There's still enough time before the November releases that we can expect that any nasty problems will show up in the buildfarm before we ship. regards, tom lane
Commits
-
In libpq for Windows, call WSAStartup once and WSACleanup not at all.
- cdc7ace161d3 9.6.20 landed
- 883226441d67 11.10 landed
- 6acc31a201d8 9.5.24 landed
- 6670e91078b3 10.15 landed
- d2074daebe16 13.1 landed
- 407580aabb83 12.5 landed
- 7d00a6b2de8a 14.0 landed
-
Update the Winsock API version requested by libpq.
- d5a9a661fcd2 14.0 landed